Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcCheckboxRadioSwitch): Pass attrs to input if available #5508

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[next] fix(NcCheckboxRadioSwitch): Pass attrs to input if available #5508

merged 1 commit into from
Jul 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 20, 2024 •
edited by susnux
Loading

Backport of #5507

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Apr 20, 2024
@susnux
Copy link
Contributor

susnux commented Apr 20, 2024

On vue3 this requires special handling, as style and class are no longer special attributes but included in attrs we need to filter them out and always apply to the root.

@susnux susnux marked this pull request as ready for review April 20, 2024 20:29
@susnux susnux force-pushed the backport/5507/next branch 3 times, most recently from 21ae8f6 to e361276 Compare April 22, 2024 13:06
@susnux susnux requested a review from ShGKme April 22, 2024 13:06
@susnux susnux requested a review from ShGKme April 22, 2024 20:56
@susnux susnux force-pushed the backport/5507/next branch 2 times, most recently from a16f5ec to c868c41 Compare April 22, 2024 21:09
@susnux susnux requested a review from Antreesy May 8, 2024 20:13
@susnux
Copy link
Contributor

susnux commented May 8, 2024

@ShGKme anything more needed? :)

@susnux susnux added this to the 9.0.0 milestone May 17, 2024
@susnux susnux mentioned this pull request May 19, 2024
Merged
@susnux susnux modified the milestones: 9.0.0, 9.0.0-alpha.4 May 28, 2024
@susnux susnux modified the milestones: 9.0.0-alpha.4, 9.0.0-alpha.5 Jul 3, 2024
@susnux susnux added this to the 9.0.0-alpha.6 milestone Jul 4, 2024
@susnux susnux mentioned this pull request Jul 8, 2024
Merged
Antreesy
Antreesy approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and aligned with last comments / original PR

@susnux
fix(NcCheckboxRadioSwitch): Pass attrs to input if available
8debebe 
If not button type, pass the attrs to the input element to allow setting aria tags like `aria-invalid` and `aria-errormessage`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 9949c44 into next Jul 8, 2024
18 checks passed
@susnux susnux deleted the backport/5507/next branch July 8, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
9.0.0-alpha.6
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ShGKme @Antreesy