Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use variables for input border width #5563

Merged
merged 1 commit into from
May 31, 2024
Merged

Use variables for input border width #5563

merged 1 commit into from
May 31, 2024

Conversation

marcoambrosini
Copy link
Contributor

Screen.Recording.2024-05-07.at.16.56.54.mov

@marcoambrosini
Copy link
Contributor Author

Waiting for server border-width variable to be in before merging this

@ShGKme
Copy link
Contributor

ShGKme commented May 7, 2024

Waiting for server border-width variable to be in before merging this

Can you link the PR? I cannot find it...

@marcoambrosini
Copy link
Contributor Author

@ShGKme it doesn't exist yet :)

jancborchardt
jancborchardt previously requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input field looks good, but for the textarea, it jumps around vertically on focus, a result of the 1px/2px change on focus.

(And yes, waiting for server for the --border-width variable.)

@jancborchardt
Copy link
Contributor

Also FYI, both commits are in here too :)

@marcoambrosini
Copy link
Contributor Author

variable here nextcloud/server@43510be

@marcoambrosini marcoambrosini mentioned this pull request May 10, 2024
Merged
@marcoambrosini marcoambrosini changed the title Reduce input border width Use variable for input border width May 13, 2024
@marcoambrosini marcoambrosini mentioned this pull request May 13, 2024
Merged
ShGKme
ShGKme reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compatibility with older server, we probably should use 2px as a fallback

src/components/NcInputField/NcInputField.vue Outdated Show resolved Hide resolved
@marcoambrosini marcoambrosini self-assigned this May 16, 2024
@marcoambrosini marcoambrosini added enhancement New feature or request 2. developing Work in progress labels May 16, 2024
@marcoambrosini
Use new border with variables
91f8a2a 
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@marcoambrosini marcoambrosini changed the title Use variable for input border width Use variables for input border width May 16, 2024
@marcoambrosini
Copy link
Contributor Author

@ShGKme I've switched back to borders, but there's still a problem with the text jumping inside on hover and focus. I've tried to change the paddings but the problem is still there. Could you please have a look?

@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 31, 2024
@susnux susnux modified the milestones: 8.13.0, 8.12.1 May 31, 2024
@susnux susnux added bug Something isn't working and removed enhancement New feature or request labels May 31, 2024
szaimen
szaimen approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@marcoambrosini marcoambrosini merged commit d508420 into master May 31, 2024
18 checks passed
@marcoambrosini marcoambrosini deleted the reduce-input-border-width branch May 31, 2024 12:11
@marcoambrosini
Copy link
Contributor Author

/backport to next

@backportbot backportbot bot mentioned this pull request May 31, 2024
Merged
@ShGKme
Copy link
Contributor

ShGKme commented May 31, 2024

but there's still a problem with the text jumping inside on hover and focus

Was it resolved?

@susnux susnux mentioned this pull request Jun 20, 2024
Merged
1 task
@Antreesy Antreesy modified the milestones: 8.12.1, 8.13.0 Jun 25, 2024
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
8.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoambrosini @ShGKme @jancborchardt @susnux @szaimen @Antreesy