[next] feat(NcAppSidebar): Allow to set open state to prevent focus trap issues on mobile #5584 #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues on mobile Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Those events are always emitted by a known state and duplicating the `open` state. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
To allow adjusting the position of the button a new `toggleClasses` prop is added. This can be use to assign custom classes to be used with the `:deep` selector. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
enhancement
ShGKme
approved these changes
May 17, 2024
GretaD
approved these changes
May 17, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #5584