-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(richText): do not handle relative links without leading slash as router links #5703
Merged
susnux
merged 1 commit into
master
from
fix/autolink--support-non-http-scheme-and-no-trailing-slash
Jun 13, 2024
Merged
fix(richText): do not handle relative links without leading slash as router links #5703
susnux
merged 1 commit into
master
from
fix/autolink--support-non-http-scheme-and-no-trailing-slash
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
Something isn't working
3. to review
Waiting for reviews
feature: avatar
Related to the avatar component
feature: richtext
Related to the richtext component
labels
Jun 13, 2024
ShGKme
force-pushed
the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
2 times, most recently
from
June 13, 2024 14:56
3c3e641
to
d43acf1
Compare
susnux
reviewed
Jun 13, 2024
ShGKme
changed the title
fix(richText): do not handle relative links without trailing slash as router links
fix(richText): do not handle relative links without leading slash as router links
Jun 13, 2024
susnux
reviewed
Jun 13, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
from
June 13, 2024 15:28
d43acf1
to
752fa36
Compare
susnux
approved these changes
Jun 13, 2024
nickvergessen
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should fix it, but didn't test
susnux
deleted the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
June 13, 2024 15:33
/backport to next |
Merged
2 tasks
4 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: avatar
Related to the avatar component
feature: richtext
Related to the richtext component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
autolink
supports relative URLs, for example,/call/ab34cd
is resolved as a Talk route.https?://
.call/abc
ormailto:email@nextcloud.ltd
also doesn't start with HTTP./
./
is enough for explicitly adding a check for non-http schemes.VueRouter handles such URLs according to the URL RFC, for example, being on
/call/abc
page, a linkdef
is resolved as/call/def
relative to/call/
. We don't want to support such links anyway, so relative URL MUST start with a slash.Alternative solution: add a leading slash
/
to relative links.🚧 Tasks
/
.🏁 Checklist
next
requested with a Vue 3 upgrade