Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcAppSidebar): make sidebar a single node again to allow v-show, classes and attributes #5725

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 20, 2024

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, susnux and ShGKme June 20, 2024 16:55
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: app-sidebar Related to the app-sidebar component labels Jun 20, 2024
@susnux susnux mentioned this pull request Jun 25, 2024
4 tasks
@ShGKme ShGKme force-pushed the backport/5627/next branch 3 times, most recently from 296869a to 473b1b0 Compare June 25, 2024 18:34
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/5627/next branch from 473b1b0 to 6e13c04 Compare June 25, 2024 18:53
@ShGKme ShGKme marked this pull request as ready for review June 25, 2024 18:59
@ShGKme
Copy link
Contributor

ShGKme commented Jun 25, 2024

@ShGKme ShGKme changed the base branch from next to backport/5608/next June 25, 2024 19:00
Base automatically changed from backport/5608/next to next June 25, 2024 19:27
@ShGKme ShGKme merged commit 9a6b32c into next Jun 25, 2024
19 checks passed
@ShGKme ShGKme deleted the backport/5627/next branch June 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants