Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichContentEditable): remove overlapping placeholder with tribute trigger #5749

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jul 1, 2024

☑️ Resolves

🙈

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added 3. to review Waiting for reviews regression Regression of a previous working feature feature: rich-contenteditable Related to the rich-contenteditable components labels Jul 1, 2024
@DorraJaouad DorraJaouad added this to the 8.13.1 milestone Jul 1, 2024
@DorraJaouad DorraJaouad requested review from ShGKme and Antreesy July 1, 2024 10:02
@DorraJaouad DorraJaouad self-assigned this Jul 1, 2024
@susnux susnux modified the milestones: 8.13.1, 8.14.0 Jul 1, 2024
@susnux susnux merged commit d2452e7 into master Jul 1, 2024
19 checks passed
@susnux susnux deleted the fix/file-picker branch July 1, 2024 11:35
@susnux
Copy link
Contributor

susnux commented Jul 1, 2024

/backport to next

@susnux
Copy link
Contributor

susnux commented Jul 4, 2024

Please always add "bug" or "enhancement" labels if the PR is not a refactoring / chore / ci / test only PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants