Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcMentionBubble): hide selectable mention id from widescreens #5753

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(NcMentionBubble): hide selectable mention id from widescreens #5753

merged 1 commit into from
Jul 2, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 1, 2024 •
edited by susnux
Loading

☑️ Resolves

  • Fix visible userid from mention bubble on widescreens (21:9, zoomed out)

🖼️ Screenshots

🏚️ Before

image

🏡 After

image

🏁 Checklist

  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcMentionBubble): hide selectable mention id from widescreens
e3fdeda 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Jul 1, 2024
@Antreesy Antreesy added this to the 8.14.0 milestone Jul 1, 2024
@Antreesy Antreesy requested review from susnux, Pytal and DorraJaouad July 1, 2024 15:32
@Antreesy Antreesy self-assigned this Jul 1, 2024
DorraJaouad
DorraJaouad reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/components/NcRichContenteditable/NcMentionBubble.vue Show resolved Hide resolved
@susnux susnux merged commit 5be7317 into master Jul 2, 2024
19 checks passed
@susnux susnux deleted the style/noid/hide-mention-bubble branch July 2, 2024 15:35
@susnux
Copy link
Contributor

susnux commented Jul 2, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Jul 2, 2024
Merged
@susnux susnux mentioned this pull request Jul 4, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @DorraJaouad