Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDialog): Ensure the dialog is correctly labelled by its name #5771

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix(NcDialog): Ensure the dialog is correctly labelled by its name #5771

merged 2 commits into from
Jul 4, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 3, 2024 •
edited
Loading

☑️ Resolves

  • Added labelId prop to NcModal to allow label modal without a name
  • Pass the navigation id (the ID of the headline element of NcDialog) to labelId
  • Added cypress tests

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Jul 3, 2024
@susnux susnux added this to the 8.14.0 milestone Jul 3, 2024
@susnux
Copy link
Contributor Author

susnux commented Jul 3, 2024

/backport to next

@susnux
fix(NcDialog): Ensure the dialog is correctly labelled by its name
7245785 
* Added `labelId` prop to NcModal to allow label modal without a name
* Pass the navigation id (the ID of the headline element of NcDialog) to `labelId`
* Added cypress tests

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(NcAppSettingsDialog): Make sure sections are correctly labelled
4ae8678 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Antreesy
Antreesy approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and tests look good!

@skjnldsv skjnldsv merged commit c42b6e1 into master Jul 4, 2024
19 checks passed
@skjnldsv skjnldsv deleted the fix/dialog-label branch July 4, 2024 07:13
@backportbot backportbot bot mentioned this pull request Jul 4, 2024
Merged
2 tasks
@susnux susnux mentioned this pull request Jul 4, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Antreesy Antreesy Antreesy approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @skjnldsv @Antreesy