-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcModal): temporary deactivate focus-traps on modal open #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
bug
Something isn't working
2. developing
Work in progress
feature: app-navigation
Related to the app-navigation component
feature: actions
Related to the actions components
labels
Jul 5, 2024
Antreesy
removed
the
feature: app-navigation
Related to the app-navigation component
label
Jul 5, 2024
Antreesy
force-pushed
the
fix/5385/focus-trap-mobile
branch
from
July 5, 2024 10:40
5ef58f6
to
8023e46
Compare
Referred to the library demo and other examples in vue-lib |
Antreesy
changed the title
wip(NcAppNavigation): provide reproducible example for focus-trap bug
fix(NcModal): temporary deactivate focus-traps on modal open
Jul 5, 2024
Antreesy
added
feature: app-navigation
Related to the app-navigation component
feature: modal
Related to the modal component
and removed
feature: actions
Related to the actions components
labels
Jul 5, 2024
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/5385/focus-trap-mobile
branch
from
July 18, 2024 10:10
8023e46
to
1f80896
Compare
Antreesy
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jul 18, 2024
susnux
approved these changes
Jul 22, 2024
ShGKme
approved these changes
Jul 22, 2024
@Antreesy we need to backport, right? |
/backport to next |
3 tasks
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: app-navigation
Related to the app-navigation component
feature: modal
Related to the modal component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Test cases:
Important
works correctly from keyboard and mouse click ✅
Important
2. Navigation header: Actions -> ActionButton (single button, don't force menu):
after closing the modal (with ESC) focus jumps to header input for a second, then to ActionButton
keyboard and mouse works fine ✅
Important
3. Navigation header: Actions -> ActionButton (close after click):
can't focus input, focus trap is inside NcAppNavigation 🐞
Important
4. Navigation header: Actions -> ActionButton (handle only click):
after mouse click on button, then on input -> focus jumps to header input 🐞
keyboard works fine
🖼️ Screenshots
🏚️ Before
Screencast.from.18.07.2024.11.30.24.webm
🏡 After
Screencast.from.18.07.2024.11.31.39.webm
🚧 Tasks
NcAppNavigationCaption
examples #5820🏁 Checklist
next
requested with a Vue 3 upgrade