fix(NcActions): Use full window height #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate the space on the window based on the trigger location. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
ShGKme
approved these changes
Jul 15, 2024
Antreesy
reviewed
Jul 15, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Antreesy
approved these changes
Jul 16, 2024
|
/backport to next |
2 tasks
Antreesy
reviewed
Jul 20, 2024
| @@ -1130,7 +1131,7 @@ export default { | |||
| */ | |||
| boundariesElement: { | |||
| type: Element, | |||
| default: () => document.querySelector('body'), | |||
| default: () => document.querySelector('#app-content-vue') ?? document.querySelector('body'), | |||
There was a problem hiding this comment.
Whoops, we didn't check, and that's breaking NcActions in the NcAppNavigation and NcAppSidebar.Shouldn't it be #content-vue, as in NcContent?
| a | b |
|---|---|
 |
 |
This was referenced Jul 20, 2024
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Calculate the space on the window based on the trigger location.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade