Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigationSettings): use tertiary styling for the toggle button #5814

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(NcAppNavigationSettings): use tertiary styling for the toggle button #5814

merged 1 commit into from
Jul 17, 2024

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Jul 17, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Bildschirmfoto_20240717_134412 Bildschirmfoto_20240717_134113 Bildschirmfoto_20240717_134125

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@st3iny
fix(NcAppNavigationSettings): use tertiary styling for the toggle button
b4fe30e 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Jul 17, 2024
@st3iny st3iny self-assigned this Jul 17, 2024
@st3iny
Copy link
Contributor Author

st3iny commented Jul 17, 2024

/backport to next

@ChristophWurst ChristophWurst merged commit 30506f2 into master Jul 17, 2024
19 checks passed
@ChristophWurst ChristophWurst deleted the fix/NcAppNavigationSettings/button-styling branch July 17, 2024 11:59
@backportbot backportbot bot mentioned this pull request Jul 17, 2024
Merged
@Antreesy Antreesy mentioned this pull request Jul 22, 2024
Merged
This was referenced Aug 14, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@hamza221 hamza221 hamza221 approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign app settings toggle so it looks like Files in Nextcloud 30
3 participants
@st3iny @ChristophWurst @hamza221