-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NcListItem: remove max width #5830
Conversation
this will break mail on list layout, most probably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the usage in the other PR does not make sense (there is no list so no list item shall be used), I think this makes sense.
I am not 100% sure about the 1-line design as now the name will be much wider but I think its ok(?)
If the name width is important than we should adjust it here by adding the |
@GretaD I did some testing and to me it looks fine actually, worst case scenario if you have a really long title this happens: But as @susnux said we can add the |
then lets do that please, add the max-width: 300 for the one line, and remove it for the rest. |
708c228
to
5f39bfd
Compare
Signed-off-by: Grigory V <scratchx@gmx.com>
5f39bfd
to
dffe5b4
Compare
/backport to next |
☑️ Resolves
🖼️ Screenshots
@miaulalala