Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcChip): Ensure chips without icon do not reserve empty space for icon #5859

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(NcChip): Ensure chips without icon do not reserve empty space for icon #5859

merged 2 commits into from
Jul 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 23, 2024 •
edited
Loading

☑️ Resolves

If there is no icon then there should be no empty space.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-07-23 at 19-22-53 Nextcloud Vue Style Guide Screenshot 2024-07-23 at 19-19-17 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Jul 23, 2024
@susnux susnux added this to the 8.15.1 milestone Jul 23, 2024
@susnux susnux requested review from Pytal, ShGKme and Antreesy July 23, 2024 17:23
@susnux
Copy link
Contributor Author

susnux commented Jul 23, 2024

/backport to next

@susnux
refactor(NcChip): Use script setup SFC
adde6f9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from ShGKme July 29, 2024 07:14
@susnux
fix(NcChip): Remove space of chip icon if not set
eae6105 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux mentioned this pull request Jul 29, 2024
Merged
Antreesy
Antreesy approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux merged commit c622ece into master Jul 29, 2024
19 checks passed
@susnux susnux deleted the fix/nc-chip-without-icon branch July 29, 2024 09:18
@backportbot backportbot bot mentioned this pull request Jul 29, 2024
Merged
2 tasks
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
8.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ShGKme @Antreesy