-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcListItem): provide additional slots for NcActions / extra actions customization #5870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure, either we:
- allow any actions, then there should be only one slot and we deprecate the
actions
slot - Only allow actions like currently, but then probably we need to allow at least an icon slot
And something like an |
Thats why I would go with 1 for the future, no? |
Then it is more complex to use because we need to define some props and events of actions |
@susnux What about another way:
So any additional buttons are added not via inline options but via a new slot as a normal buttons? |
This I think makes really sense!
Do you have a use case for this on Talk? Otherwise I think it is not a good idea to have multiple buttons here. |
4300707
to
4ea068a
Compare
4ea068a
to
8aefc8e
Compare
Ah ok makes sense. (OT: I really do not like this component it is so complex to fit every use case even if it would be simpler to just create a just custom component for it, while most often use case is just"a simple listitem"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the comment by @ShGKme (template v-if) otherwise fine
- extra-actions for inline component - actions-icon for icon in NcActions component Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
8aefc8e
to
2d26aad
Compare
/backport to next |
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade