Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcNoteCard): Adjust padding and margin #5893

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix(NcNoteCard): Adjust padding and margin #5893

merged 1 commit into from
Aug 5, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 2, 2024 •
edited
Loading

☑️ Resolves

Adjust the padding and margin to be a bit more condensed. Also fixed the documentation as the text was incomplete.

🖼️ Screenshots

Screenshot 2024-08-02 at 03-47-05 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: note-card Related to the note-card component labels Aug 2, 2024
@susnux susnux added this to the 8.15.2 milestone Aug 2, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 2, 2024

/backport to next

Antreesy
Antreesy reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general - good, we can drop some custom styles for it in Talk now =)

src/components/NcNoteCard/NcNoteCard.vue Outdated Show resolved Hide resolved
src/components/NcNoteCard/NcNoteCard.vue Outdated Show resolved Hide resolved
@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@susnux
fix(NcNoteCard): Adjust padding and margin
df6abb6 
Adjust the padding and margin to be a bit more condensed.
Also fixed the documentation as the text was incomplete.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from Antreesy August 5, 2024 11:43
@susnux susnux merged commit 3cc32bd into master Aug 5, 2024
19 checks passed
@susnux susnux deleted the fix/nc-note-card branch August 5, 2024 11:55
@backportbot backportbot bot mentioned this pull request Aug 5, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: note-card Related to the note-card component
Projects
None yet
Milestone
8.16.0
Development

Successfully merging this pull request may close these issues.

NcNoteCard padding and alignment
4 participants
@susnux @marcoambrosini @Antreesy @ShGKme