Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActions): Role menu needs a label assigned so label by trigger #5933

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 6, 2024

☑️ Resolves

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role

The menu needs a label set, so lets add it similar to dialog role. In general we could consider always add it to the ul as this is pretty valid and has good browser support.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 6, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@susnux
Copy link
Contributor Author

susnux commented Aug 6, 2024

/backport to next

@Pytal Pytal merged commit 60abbab into master Aug 7, 2024
19 checks passed
@Pytal Pytal deleted the fix/actions-label branch August 7, 2024 17:35
Copy link

backportbot bot commented Aug 7, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5933/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17f5bc1a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5933/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

/backport to next

Copy link

backportbot bot commented Aug 8, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5933/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17f5bc1a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5933/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities backport-request bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants