Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSettingsDialog): Adjust navigation entries to match Nextcloud 30 design #5963

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(NcAppSettingsDialog): Adjust navigation entries to match Nextcloud 30 design #5963

merged 1 commit into from
Aug 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 15, 2024 •
edited
Loading

☑️ Resolves

Ensure correct border radius and padding is used.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-08-15 at 02-46-37 Nextcloud Vue Style Guide Screenshot 2024-08-15 at 02-45-57 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux
fix(NcAppSettingsDialog): Adjust navigation entries to match Nextclou…
092e276 
…d 30 design

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Aug 15, 2024
@susnux susnux added this to the 8.16.1 milestone Aug 15, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 15, 2024

/backport to next

@susnux susnux mentioned this pull request Aug 15, 2024
Closed
28 tasks
ShGKme
ShGKme approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like paddings in navigation are too huge in comparison with other containers and dialogs. Maybe decrease it to 2*base?

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2024

I already reduced them a bit, can we do the rest in a follow up? Because shrinking it further that needs special handling for 29 and 28.
And basically unrelated to the border radius issue I wanted to fix here 😅

@susnux susnux merged commit 1b8d6fc into master Aug 19, 2024
19 checks passed
@susnux susnux deleted the fix/app-settings-design branch August 19, 2024 12:36
@backportbot backportbot bot mentioned this pull request Aug 19, 2024
Merged
@susnux susnux mentioned this pull request Aug 20, 2024
Merged
@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
8.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ShGKme @marcoambrosini