Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcListItem): allow to control the display of a three dot menu #5980

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat(NcListItem): allow to control the display of a three dot menu #5980

merged 1 commit into from
Aug 19, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

The other general solution is to use actionsProps prop. It can be a better solution if we often want to customize NcActions in NcListItem in depth

🖼️ Screenshots

There is one action

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added enhancement New feature or request 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Aug 19, 2024
@DorraJaouad DorraJaouad added this to the 8.16.1 milestone Aug 19, 2024
@DorraJaouad DorraJaouad requested review from susnux and ShGKme August 19, 2024 11:32
@DorraJaouad DorraJaouad self-assigned this Aug 19, 2024
@DorraJaouad
Copy link
Contributor Author

/backport to next

@DorraJaouad
fix(NcListItem): allow to control the display of a three dot menu
4874f91 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/control-menu-display-nclistitem branch from d55b8db to 4874f91 Compare August 19, 2024 11:35
Antreesy
Antreesy approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks enough for common use-cases. actions-props might be too much, I remember we gave up this idea 1-2 PRs ago

@susnux susnux merged commit 73b3ca0 into master Aug 19, 2024
19 checks passed
@susnux susnux deleted the fix/control-menu-display-nclistitem branch August 19, 2024 17:33
@backportbot backportbot bot mentioned this pull request Aug 19, 2024
Merged
@susnux susnux mentioned this pull request Aug 20, 2024
Merged
@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@ShGKme ShGKme changed the title fix(NcListItem): allow to control the display of a three dot menu feat(NcListItem): allow to control the display of a three dot menu Aug 20, 2024
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews enhancement New feature or request feature: list-item Related to the list-item component
Projects
None yet
Milestone
8.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @susnux @ShGKme @Antreesy