Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigationCaption): make name ellipsize #5982

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

GVodyanov
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

I removed padding-right in order for the text to not ellipsize too early

🏚️ Before 🏡 After
image image

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Aug 19, 2024
@GVodyanov GVodyanov self-assigned this Aug 19, 2024
@ShGKme ShGKme changed the title NcAppNavigationCaption: make name ellipsize fix(NcAppNavigationCaption): make name ellipsize Aug 19, 2024
@ShGKme ShGKme added the bug Something isn't working label Aug 19, 2024
@ShGKme ShGKme added this to the 8.16.1 milestone Aug 19, 2024
@GretaD GretaD merged commit 323b5d9 into master Aug 19, 2024
19 checks passed
@GretaD GretaD deleted the fix/navigation-caption-ellipsizing branch August 19, 2024 17:16
@susnux susnux mentioned this pull request Aug 20, 2024
@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@LostinSpacetime
Copy link

Any progress on this?

@hamza221
Copy link
Contributor

Any progress on this?

it's merged

@M-Wiemann
Copy link

Nextcloud 30.0.1 integrates the version 8.17.1.
package.json:
"@nextcloud/vue": "^8.17.1"

But the problem still exist.
Any idea why?

@ShGKme
Copy link
Contributor

ShGKme commented Nov 6, 2024

Works fine for me on Nextcloud 30

@M-Wiemann Could you check in the devtools what styles does it have and where the wrong style comes from?

@LostinSpacetime
Copy link

I also still have the problem with 30.0.1

@M-Wiemann
Copy link

M-Wiemann commented Nov 7, 2024

@ShGKme
when i change flex-shrink from 0 to 1, it works.
It is in the class .app-navigation-caption__name in the file NcAppNavigationCaption-CYv7YhUS.css
/apps/mail

/**
 * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */
/**
 * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */
/*
* Ensure proper alignment of the vue material icons
*/
.material-design-icon[data-v-574a55ae] {
  display: flex;
  align-self: center;
  justify-self: center;
  align-items: center;
  justify-content: center;
}
.app-navigation-caption[data-v-574a55ae] {
  display: flex;
  justify-content: space-between;
}
.app-navigation-caption--heading[data-v-574a55ae] {
  padding: var(--app-navigation-padding);
}
.app-navigation-caption--heading[data-v-574a55ae]:not(:first-child):not(:last-child) {
  padding: 0 var(--app-navigation-padding);
}
.app-navigation-caption__name[data-v-574a55ae] {
  font-weight: bold;
  color: var(--color-main-text);
  font-size: var(--default-font-size);
  line-height: var(--default-clickable-area);
  white-space: nowrap;
  overflow: hidden;
  text-overflow: ellipsis;
  box-shadow: none !important;
  flex-shrink: 0;
  padding: 0 calc(var(--default-grid-baseline, 4px) * 2) 0 calc(var(--default-grid-baseline, 4px) * 2);
  margin-top: 0px;
  margin-bottom: var(--default-grid-baseline);
}
.app-navigation-caption__actions[data-v-574a55ae] {
  flex: 0 0 var(--default-clickable-area);
}
.app-navigation-caption[data-v-574a55ae]:not(:first-child) {
  margin-top: calc(var(--default-clickable-area) / 2);
}

@ShGKme
Copy link
Contributor

ShGKme commented Nov 7, 2024

Oh, I missed that is about Mail, not server...

Nextcloud 30.0.1 integrates the version 8.17.1.
package.json:
"@nextcloud/vue": "^8.17.1"

This is a server version and dependency, not Mail.

Mail v4.0.2 doesn't have upgraded @nextcloud/vue, it uses v8.16.0. It's upgraded the Mail's main and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account email ellipsized too late
7 participants