fix(NcCounterBubble): increase size #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
requested review from
jancborchardt,
susnux,
marcoambrosini,
DorraJaouad and
Antreesy
ShGKme
force-pushed
the
fix/nc-counter-bubble-size
branch
from
e9b04cf
to
0080220
Compare
marcoambrosini
approved these changes
Aug 20, 2024
Antreesy
approved these changes
Aug 20, 2024
DorraJaouad
approved these changes
Aug 20, 2024
jancborchardt
approved these changes
Aug 20, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-counter-bubble-size
branch
from
0080220
to
acb7cbf
Compare
|
Rebased onto |
|
Checked on stable28 |
Merged
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
1.5 * grid(applies only to large numbers)1capwas not very well supported from fix(NcCounterBubble): make it perfectly aligned circle #5948line-heightto expand height and center text instead of1cap🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade