fix(NcRichContenteditable): adjust to new design #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
|
Requires some more fixes to prevent changes in 28 |
Merged
ShGKme
force-pushed
the
fix/NcRichContenteditable--adjust-design
branch
from
830e1b5 to
0b1316f
Compare
ShGKme
added
3. to review
ShGKme
commented
Aug 20, 2024
Comment on lines
132
to
134
| --auto-complete-result-status-icon-size: clamp(14px, var(--auto-complete-result-avatar-size) * 0.4, 18px); | ||
| // 2 * Avatar Radius * (1 - 1 / sqrt(2)) - Status Icon Size / 2 | ||
| --auto-complete-result-status-icon-position: calc(var(--auto-complete-result-avatar-size) / 2 * (1 - 1 / sqrt(2)) - var(--auto-complete-result-status-icon-size) / 2); |
There was a problem hiding this comment.
If it goes well, I'll try to adapt it to NcAvatar and then use NcAvatar here to not duplicate it.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/NcRichContenteditable--adjust-design
branch
from
0b1316f to
3b0dc0f
Compare
|
/backport to next |
susnux
reviewed
Aug 20, 2024
| @@ -127,21 +129,22 @@ export default { | |||
| } | |||
|
|
|||
| &__status { | |||
| --auto-complete-result-status-icon-size: clamp(14px, var(--auto-complete-result-avatar-size) * 0.4, 18px); | |||
| // Avatar Radius * (1 - 1 / sqrt(2)) - Status Icon Radius / 2 | |||
susnux
reviewed
Aug 20, 2024
| min-height: 18px; | ||
| width: 18px; | ||
| height: 18px; | ||
| right: var(--auto-complete-result-status-icon-position); |
There was a problem hiding this comment.
Suggested change
| right: var(--auto-complete-result-status-icon-position); | |
| inset-inline-end var(--auto-complete-result-status-icon-position); |
susnux
reviewed
Aug 20, 2024
| @@ -1246,7 +1247,7 @@ export default { | |||
| width: 20px; | |||
| height: 20px; | |||
| object-fit: contain; | |||
| padding-right: calc(var(--default-grid-baseline) * 2); | |||
| padding-right: var(--default-grid-baseline); | |||
There was a problem hiding this comment.
Suggested change
| padding-right: var(--default-grid-baseline); | |
| padding-inline-end: var(--default-grid-baseline); |
susnux
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🚧 Tasks
box-sizing: border-boxso it doesn't break if mounted to bodyNote, it has some copy-paste from
NcAvatarandNcListItem. We can look at reuse in a follow-up🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade