fix(NcCheckBoxRadioSwitch): do not toggle on a click on a link inside #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a link Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
added
3. to review
ShGKme
approved these changes
Aug 23, 2024
|
But generally speaking, it is not valid to put an interactive element into another interactive element, and it fails a11y check |
ShGKme
changed the title
Agree 🙈 , maybe we need to alter component to be interactive on checkbox level only (at least needed for |
|
/backport to next |
I was thinking the same. Task lists should probably not put the content inside the checkbox (if not only text) |
Merged
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a link
☑️ Resolves
In rich text > tasks list, check boxes can have links
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade