Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useHotKey): respect press of MacOS Cmd key as Ctrl key #6021

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix(useHotKey): respect press of MacOS Cmd key as Ctrl key #6021

merged 1 commit into from
Aug 30, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 28, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

No visual changes

🚧 Tasks

  • Test on MacOS: Should allow to copy text with Cmd+C, if hotkey for 'C' is assigned

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added 3. to review Waiting for reviews regression Regression of a previous working feature labels Aug 28, 2024
@Antreesy Antreesy added this to the 8.17.1 milestone Aug 28, 2024
@Antreesy Antreesy self-assigned this Aug 28, 2024
@Antreesy Antreesy marked this pull request as ready for review August 28, 2024 12:43
@Antreesy @susnux
fix(useHotKey): respect press of MacOS Cmd key as Ctrl key
1062676 
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@susnux susnux force-pushed the fix/5899/macos-support-hotkey branch from 8384217 to 1062676 Compare August 30, 2024 10:46
@Antreesy
Copy link
Contributor Author

/backport to next

@Antreesy Antreesy merged commit 96a9703 into master Aug 30, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/5899/macos-support-hotkey branch August 30, 2024 11:24
@backportbot backportbot bot mentioned this pull request Aug 30, 2024
Merged
@susnux susnux mentioned this pull request Aug 30, 2024
Merged
@Antreesy Antreesy mentioned this pull request Sep 12, 2024
Open
58 tasks
@ShGKme ShGKme mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews regression Regression of a previous working feature
Projects
None yet
Milestone
8.17.1
Development

Successfully merging this pull request may close these issues.

CMD+C on MacOS focusses message input instead of copy
3 participants
@Antreesy @susnux @ShGKme