Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): Pressing escape should always close the actions #6037

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(NcActions): Pressing escape should always close the actions #6037

merged 1 commit into from
Sep 2, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 2, 2024 •
edited
Loading

☑️ Resolves

  1. Opening actions, then e.g. right-click for context menu.
  2. Now press escape -> context menu closes
  3. Press escape again -> nothing happens
  4. (with this commit): Pressing it a second time will close the actions as expected

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Sep 2, 2024
@susnux susnux added this to the 8.18.0 milestone Sep 2, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 2, 2024

/backport to next

raimund-schluessler

This comment was marked as resolved.

Sign in to view

@susnux
fix(NcActions): Pressing escape should always close the actions
1f2a788 
1. Opening actions, then e.g. right-click for context menu.
2. Now press escape -> context menu closes
3. Press escape again -> nothing happens
4. (with this commit): Pressing it a second time will close the actions as expected

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 7889144 into master Sep 2, 2024
19 checks passed
@susnux susnux deleted the fix/actions-escape branch September 2, 2024 16:02
@backportbot backportbot bot mentioned this pull request Sep 2, 2024
Merged
This was referenced Sep 12, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @raimund-schluessler @ShGKme @Antreesy