-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcActions): Emit closed
event only when the actions are fully closed
#6065
Conversation
What about close/closed ? I usually prefer to have both options when there is an animation :) |
The "state changed but still visible" event is already available with So if you need the Maybe we should rename the event in the next major to |
Or keep both 🙈 |
Only if one is deprecated in v8 and removed in v9. Otherwise why have 2 names for an event? |
|
5bb6b1d
to
f17f588
Compare
close
event only when the actions are fully closedcloses
event only when the actions are fully closed
closes
event only when the actions are fully closedclosed
event only when the actions are fully closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
We have the same events firing at NcAppSidebar, should be noted/fixed there as well?
The flow is like: 1. Close the actions 2. `update:open` with `false` is emitted (+ deprecated 'close' event) 3. Actions popover closes (transistion) 4. `closed` is emitted Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
f17f588
to
c729694
Compare
☑️ Resolves
The flow is like:
update:open
withfalse
is emittedclose
is emittedFixes flashing changes in the menu if you have conditionals like submenus.
🏁 Checklist
next
requested with a Vue 3 upgrade