Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): RTL support #6150

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(NcSelect): RTL support #6150

merged 1 commit into from
Oct 21, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 17, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221 hamza221 self-assigned this Oct 17, 2024
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Oct 17, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Oct 17, 2024

This also changed the input direction. Not sure it was intended

@ShGKme ShGKme added this to the 8.19.1 milestone Oct 17, 2024
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221
Copy link
Contributor Author

This also changed the input direction. Not sure it was intended

That was not intended, Now the input dir depends on the input language

@susnux
Copy link
Contributor

susnux commented Oct 20, 2024

/backport to next

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested visually =)
image
image

@susnux susnux merged commit 1525bd9 into master Oct 21, 2024
19 checks passed
@susnux susnux deleted the fix/rtl/ncselect branch October 21, 2024 09:53
@Antreesy Antreesy modified the milestones: 8.19.1, 8.20.0 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants