Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcModal): rtl support #6171

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(NcModal): rtl support #6171

merged 1 commit into from
Oct 29, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 28, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221 hamza221 self-assigned this Oct 28, 2024
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Oct 28, 2024
@ShGKme ShGKme changed the title fix(modal): rtl support fix(NcModal): rtl support Oct 28, 2024
@ShGKme ShGKme added this to the 8.19.1 milestone Oct 28, 2024
src/components/NcModal/NcModal.vue Outdated Show resolved Hide resolved
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 merged commit 777d206 into master Oct 29, 2024
19 checks passed
@hamza221 hamza221 deleted the fix/nc-modal-rtl branch October 29, 2024 13:53
@hamza221
Copy link
Contributor Author

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants