fix(NcRichContenteditable): do not break adjacent mentions #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
bug
DorraJaouad
approved these changes
Nov 16, 2024
susnux
approved these changes
Nov 19, 2024
- when injecting HTML template, newlines, tabs and consecutive whitespaces should be stripped - when parsing innerHTML (reverse process), collapsing of whitespacing also affecting two adjacent HTML templates - parsed ids without whitespace will be joined and won't be rendered next time Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- sanitized strings are skipped Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/strip-off-whitespaces
branch
from
7733d71 to
f62f921
Compare
|
/backport to next |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
nextrequested with a Vue 3 upgrade