fix(NcAppContent): white splitter in dark mode when using split-horizontal mode #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
reviewed
Nov 18, 2024
ShGKme
added
bug
…ontal mode Signed-off-by: Wolfgang <github@linux-dude.de>
wofferl
force-pushed
the
fix_horizontal_splitter
branch
from
599f9f0 to
a4bb820
Compare
susnux
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6227 +/- ##
==========================================
- Coverage 42.74% 42.62% -0.12%
==========================================
Files 153 154 +1
Lines 4029 4040 +11
Branches 1015 1017 +2
==========================================
Hits 1722 1722
- Misses 2195 2206 +11
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ShGKme
approved these changes
Nov 19, 2024
|
/backport to next |
|
@wofferl Thank you for your contribution |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
In dark Mode the background-color of the splitter are not correctly adjusted.
This PR adds the missing css for the horizontal splitter.