Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): support email mentions #6233

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(NcRichContenteditable): support email mentions #6233

merged 1 commit into from
Nov 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 19, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Nov 19, 2024
@Antreesy Antreesy added this to the 8.20.1 milestone Nov 19, 2024
@Antreesy Antreesy self-assigned this Nov 19, 2024
@Antreesy Antreesy mentioned this pull request Nov 19, 2024
Merged
9 tasks
susnux
susnux approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but would feel better if you add unit tests

@Antreesy
fix(NcRichContenteditable): support email mentions
cbd2a6a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/mention-emails branch from ca5489a to cbd2a6a Compare November 19, 2024 13:18
@Antreesy Antreesy enabled auto-merge November 19, 2024 13:18
@Antreesy
Copy link
Contributor Author

/backport to next

@Antreesy Antreesy merged commit 46d9db5 into master Nov 19, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/mention-emails branch November 19, 2024 13:23
@backportbot backportbot bot mentioned this pull request Nov 19, 2024
Merged
@Antreesy Antreesy mentioned this pull request Nov 21, 2024
Merged
@Antreesy Antreesy modified the milestones: 8.20.1, 8.21.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @susnux