fix(NcRichContenteditable): past content to an empty field fails #6241
Conversation
DorraJaouad
added
bug
DorraJaouad
force-pushed
the
fix/4821/pasted-text
branch
from
082ab64 to
236385b
Compare
| if (!this.isFF || !window.getSelection) { | ||
| return | ||
| } |
There was a problem hiding this comment.
If you remove this method, isFF is also not needed anymore.
There was a problem hiding this comment.
Unrelated to pasting issue, but noticed:
if input is started or ended with embedded HTML (mention) "@Test01 anyword @Test01":
- 🐞 in FF cursor isn't moving to the very start or end with ⬅️ ➡️ keys (⬆️ ⬇️ are working)
- 🐞 in Safari cursor jumps to the very beginning
- ✅ in Chrome everything is fine
| // Some browsers add a newline at the end of the contenteditable | ||
| text = text === '\n' ? '' : text |
There was a problem hiding this comment.
The comment seems to not document the following line. Let's adjust to something like
| // Some browsers add a newline at the end of the contenteditable | |
| text = text === '\n' ? '' : text | |
| // Browsers keep <br> after erasing contenteditable | |
| text = text === '\n' ? '' : text |
- Some browsers => browsers (it is not browser-specific. Or is it?)
- At the end => after erasing (not the ending but entire content is checked)
There was a problem hiding this comment.
const text = this.parseContent(htmlOrText).replace(/^\n$/, '')Tried to put it in parseContent, but it's breaking the component due to comparing trimmed values, so should be good here
DorraJaouad
force-pushed
the
fix/4821/pasted-text
branch
from
236385b to
04830b9
Compare
|
Output raw still has a |
We don't remove it when there is text because browser will add it anyway, we remove when it's the only text (browser leftover) |
It doesn't hurt (unlike then it contains only |
|
/backport to next |
| // Some browsers add a newline at the end of the contenteditable | ||
| text = text === '\n' ? '' : text |
There was a problem hiding this comment.
const text = this.parseContent(htmlOrText).replace(/^\n$/, '')Tried to put it in parseContent, but it's breaking the component due to comparing trimmed values, so should be good here
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…is content) Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…e but has one new line (browser dependent) Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/4821/pasted-text
branch
from
04830b9 to
6267b67
Compare
ShGKme
changed the title
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade