-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcRichContenteditable): remove value linkify #6372
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
We're not using that component in text/collextives |
That seemed like a good feature, why are we removing this now? |
Probably because there is no usecase and not documented? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking for Talk anymore
/backport to next |
☑️ Resolves
NcRichContenteditable has a hidden feature: when a content is set outside (not inputted⚠️ ), it's linkified.
@juliusknorr @mejo- Could you confirm you don't rely on this behavior in text/collectives?
🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade