Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichContenteditable): remove value linkify #6372

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 13, 2025

☑️ Resolves

NcRichContenteditable has a hidden feature: when a content is set outside (not inputted ⚠️), it's linkified.

@juliusknorr @mejo- Could you confirm you don't rely on this behavior in text/collectives?

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 2. developing Work in progress feature: rich-contenteditable Related to the rich-contenteditable components labels Jan 13, 2025
@ShGKme ShGKme added this to the 8.21.1 milestone Jan 13, 2025
@ShGKme ShGKme self-assigned this Jan 13, 2025
@juliusknorr
Copy link
Contributor

We're not using that component in text/collextives

@ShGKme ShGKme marked this pull request as ready for review January 13, 2025 20:30
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 13, 2025
@skjnldsv
Copy link
Contributor

That seemed like a good feature, why are we removing this now?

@susnux
Copy link
Contributor

susnux commented Jan 14, 2025

That seemed like a good feature, why are we removing this now?

Probably because there is no usecase and not documented?
Also my problem is more that the UX is different if inputted / content from outside, so consistent behavior (remove or both) or feature toggle would be good I think.

@Antreesy
Copy link
Contributor

Antreesy commented Jan 14, 2025

We're actually using this mixin to render description (as per original PR):
image
image

Maybe make it optional, so that NcRichContentEditable doesn't render links inside of editable content, but presenting components do?

Or we'll just migrate to NcRichText here 👀

@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking for Talk anymore

@Antreesy
Copy link
Contributor

/backport to next

@Antreesy Antreesy merged commit 654f398 into master Feb 13, 2025
20 checks passed
@Antreesy Antreesy deleted the fix/NcRichContenteditable--remove-linkify branch February 13, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants