Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bidi): NcAvatar status and interactivity toggle button #6407

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix(bidi): NcAvatar status and interactivity toggle button #6407

merged 2 commits into from
Jan 21, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 21, 2025 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad
fix(NcAvatar): adjust the status placement based on language direction
6fbd432 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added 3. to review Waiting for reviews feature: avatar Related to the avatar component RTL Right-to-Left languages support labels Jan 21, 2025
@DorraJaouad DorraJaouad added this to the 8.23.0 milestone Jan 21, 2025
@DorraJaouad DorraJaouad self-assigned this Jan 21, 2025
susnux
susnux approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ShGKme
Copy link
Contributor

ShGKme commented Jan 21, 2025

/backport to next

@DorraJaouad
fix(NcReferenceWidget): bidi for toggle button
140a41e 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
Copy link
Contributor Author

I added bidi for the toggle button in reference widget

@DorraJaouad DorraJaouad changed the title fix(NcAvatar): adjust the status placement based on language direction fix(bidi): NcAvatar status and interactivity toggle button Jan 21, 2025
@Antreesy Antreesy merged commit 9210452 into master Jan 21, 2025
19 checks passed
@Antreesy Antreesy deleted the fix/noid/bidi-avatar-status branch January 21, 2025 11:22
@backportbot backportbot bot mentioned this pull request Jan 21, 2025
Merged
@Antreesy Antreesy added the bug Something isn't working label Feb 11, 2025
@Antreesy Antreesy mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component RTL Right-to-Left languages support
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @ShGKme @susnux @Antreesy