Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Improve accessibility with correct attributes #30

Merged
merged 6 commits into from
Jan 9, 2024
Merged

enh(a11y): Improve accessibility with correct attributes #30

merged 6 commits into from
Jan 9, 2024

Conversation

Pytal
Copy link
Collaborator

@Pytal Pytal commented Dec 15, 2023

@Pytal Pytal added this to the 3.25.0 milestone Dec 15, 2023
@Pytal Pytal requested a review from ShGKme December 15, 2023 05:47
@Pytal Pytal self-assigned this Dec 15, 2023
@ShGKme ShGKme mentioned this pull request Jan 5, 2024
Closed
ShGKme
ShGKme suggested changes Jan 5, 2024
View reviewed changes
Copy link

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the issues are solved, great!

The only problem for me is the open indicator with a new button and attrs (see comments).

Also, the open indicator doesn't work for opening for me now.

select-bug

src/components/Select.vue Outdated Show resolved Hide resolved
src/components/Select.vue Outdated Show resolved Hide resolved
src/components/Select.vue Show resolved Hide resolved
src/components/Select.vue Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the enh/a11y/attributes branch 8 times, most recently from ebfc8c9 to 8bcbdb2 Compare January 6, 2024 01:05
@Pytal
enh(a11y): Improve accessibility with correct attributes
864a7e9 
- Move accessibility attributes from wrapper to input
- Move uid from dropdown toggle element id to wrapper
- Wrap open indicator icon with button element
- Handle toggle dropdown on selected options to not conflict with open indicator button
- Label listbox element

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test: Test uid on wrapper
9fda5a1 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test: Test open indicator
f95ca7f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test: Test aria-expanded on search input
c6b2c8e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test: Test selected options wrapper
60d20db 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(ci): Bump max js bundle size
ec26624 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from ShGKme January 9, 2024 00:13
@Pytal Pytal merged commit 0bd4d78 into master Jan 9, 2024
2 checks passed
@Pytal Pytal deleted the enh/a11y/attributes branch January 9, 2024 00:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

🎉 This PR is included in version 3.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
accessibility released
Projects
None yet
Milestone
3.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @ShGKme