Use Asset Modules plus upgrade to npm 7 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
requested review from
raimund-schluessler,
juliusknorr,
korelstar,
artonge and
skjnldsv
|
Do we need to specify the engines in |
|
Would be nice @raimund-schluessler 🚀 |
- Use backwards-compatible lockfile version 2, docs https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion - Require npm >=7.0.0 in package engines Signed-off-by: Christopher Ng <chrng8@gmail.com>
- Introduced in webpack v5 https://webpack.js.org/guides/asset-modules/ Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/asset-modules
branch
from
c1527b9
to
2ab3f1b
Compare
It's backwards compatible but I've added it for consistency across the nextcloud ecosystem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Asset Modules introduced in webpack 5 and upgrade to npm 7
Docs https://webpack.js.org/guides/asset-modules/