Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change webpack config for more platform independency #268

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Change webpack config for more platform independency #268

merged 2 commits into from
Jan 3, 2022

Conversation

dartcafe
Copy link
Contributor

@dartcafe dartcafe commented Jan 2, 2022

@dartcafe dartcafe added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Jan 2, 2022
@dartcafe dartcafe mentioned this pull request Jan 2, 2022
Merged
@dartcafe
use --node-env instead of NODE_ENV=
da9dce0 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
changed config filename to default name webpack.config.js
e0eb6b2 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe mentioned this pull request Jan 2, 2022
Merged
@artonge artonge merged commit 7184bd6 into master Jan 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/webpack-config branch January 3, 2022 09:37
@st3iny st3iny mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dartcafe @artonge