Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put vue as dependency to sync with vue-template-compiler #371

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 7, 2022

If apps/libs have their own vue dep, it makes updating this complicated as both deps needs to be updated simultaneously.
By having them all in @nextcloud/webpack-vue-config, we allos to upgrade them in the same flow

UPDATED: Manually downgraded the tests vue version, so that we can have a look and see if that works.
Theoretically, we should see the @nextcloud/webpack-vue-config's vue and vue-template-compiler version take over as deduped dependencies.

$ npm ls vue
webpack-vue-config-test@1.0.0 /home/admin/git/webpack-vue-config/tests
├─┬ @nextcloud/webpack-vue-config@5.4.0
│ └── vue@2.7.13 deduped
└── vue@2.7.13

@skjnldsv skjnldsv self-assigned this Aug 7, 2022
@skjnldsv skjnldsv added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 7, 2022
@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix/vue-as-dep branch 3 times, most recently from b7a2303 to dbc0609 Compare August 9, 2022 07:18
@skjnldsv skjnldsv force-pushed the fix/vue-as-dep branch 2 times, most recently from d88c91b to d850073 Compare October 29, 2022 08:32
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 6113ea1 into master Oct 29, 2022
@skjnldsv skjnldsv deleted the fix/vue-as-dep branch October 29, 2022 08:39
@skjnldsv skjnldsv mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant