Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update http-foundation, routing and translation to 5.4.24 #1482

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore: update http-foundation, routing and translation to 5.4.24 #1482

merged 1 commit into from
Jul 19, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 19, 2023

No description provided.

@kesselb
chore: update http-foundation, routing and translation to 5.4.24
8a78b41 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this pull request Jul 19, 2023
Merged
8 tasks
@kesselb kesselb self-assigned this Jul 19, 2023
mejo-
mejo- approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking into the details of code changes from the updated dependencies, looks sensible to me.

nickvergessen
nickvergessen approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be a bit tough to track back individual errors, if we face a regression, but fine by me. In worst case we would need to revert all three and try again.

@kesselb kesselb merged commit 593f3f5 into master Jul 19, 2023
7 checks passed
@kesselb kesselb deleted the bump-symfony-http-routing-translation branch July 19, 2023 21:18
This was referenced Aug 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mejo- mejo- mejo- approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@kesselb kesselb

Labels
3. to review dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @nickvergessen @mejo-