Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mp3info): apply upstream patch for invalid array access #1888

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore(mp3info): apply upstream patch for invalid array access #1888

merged 1 commit into from
Jul 4, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 3, 2024

@kesselb
chore(mp3info): apply upstream patch for invalid array access
08580a1 
Patch: wapmorgan/Mp3Info#36

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this pull request Jul 3, 2024
Merged
7 tasks
@kesselb kesselb self-assigned this Jul 3, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jul 3, 2024
joshtrichards
joshtrichards approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Caveat: Learning Composer Patches has been on my to-learn list. So that part I reviewed against the docs. :-)

@kesselb kesselb merged commit 72598dd into master Jul 4, 2024
7 checks passed
@kesselb kesselb deleted the bug/noid/patch-mp3-lib branch July 4, 2024 08:49
@kesselb
Copy link
Contributor Author

kesselb commented Jul 4, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jul 4, 2024
Merged
2 tasks
@joshtrichards
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 6, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@joshtrichards joshtrichards joshtrichards approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@kesselb kesselb

Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @joshtrichards @susnux