chore: set version in composer.json #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running dump-autoload, then composer tries to find a matching version number. Sometimes the VCS detection does not work and the generated version number changes from the commit hash to the fallback and back to the generated version when someone else updates the package. We are now using a version number in composer.json to avoid a version number ping-pong. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
commented
Jul 4, 2024
| @@ -1568,12 +1568,12 @@ | |||
| "version": "v5.2.13", | |||
| "source": { | |||
| "type": "git", | |||
| "url": "https://github.com/justinrainbow/json-schema.git", | |||
| "url": "https://github.com/jsonrainbow/json-schema.git", | |||
There was a problem hiding this comment.
I've updated the lockfile with composer update --no-dev --lock and therefore we are seeing the updated hash for the relocated repo here.
nickvergessen
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running dump-autoload, then composer tries to find a matching version number.
Sometimes the VCS detection does not work and the generated version number changes from the commit hash to the fallback and back to the generated version when someone else updates the package.
We are now using a version number in composer.json to avoid a version number ping-pong.