Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Bump christophwurst/id3parser to 0.1.4 #966

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 14, 2022

Backport of #937

This is needed because it fixes compatibility with PHP 8 which is supported by Nextcloud 21, 22 and 23.

@st3iny st3iny self-assigned this Jan 14, 2022
@st3iny st3iny changed the title Bump christophwurst/id3parser to 0.1.4 [stable23] Bump christophwurst/id3parser to 0.1.4 Jan 14, 2022
@nickvergessen

This comment was marked as outdated.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/update-id3parser/stable23 branch from 34e9c90 to 138937f Compare June 3, 2022 11:18
@st3iny
Copy link
Member Author

st3iny commented Jun 3, 2022

I gave this another shot and used the script from #964 (comment) this time.

@st3iny st3iny requested review from come-nc and CarlSchwan June 3, 2022 11:22
@st3iny st3iny merged commit 8f9c6c1 into stable23 Jun 10, 2022
@st3iny st3iny deleted the fix/update-id3parser/stable23 branch June 10, 2022 08:54
@nickvergessen
Copy link
Member

Please always send the PR for server first, so we see tests still pass there before merging 3rdparty.
Now you basically locked 3rdparty and we can't merge any other dependency if your tests fail

@st3iny
Copy link
Member Author

st3iny commented Jun 10, 2022

Please always send the PR for server first, so we see tests still pass there before merging 3rdparty. Now you basically locked 3rdparty and we can't merge any other dependency if your tests fail

Will do! Thanks for the hint. This was my first 3rdparty bump + backport.

@nickvergessen
Copy link
Member

grafik

@blizzz blizzz mentioned this pull request Jun 10, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants