Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Sign On E2E test concept #395

Open
stefan-niedermann opened this issue Oct 28, 2021 · 5 comments · May be fixed by #404
Open

Single Sign On E2E test concept #395

stefan-niedermann opened this issue Oct 28, 2021 · 5 comments · May be fixed by #404

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Oct 28, 2021

This document is subject of change at all time based on feedback in the comments.

ℹ️ Terms

🙋‍♂ Motivation

The files app 3.18-RC1 introduced an issue which caused all 3rd party apps stop working. The aftermaths were complaining users, increased support efforts and 1-star ratings. We should avoid this in the future.

🏁 Goal

  1. When changes in the files app or in the SSO lib lead to a breaking change, we must get notified
  2. Having an real end to end test, which covers the flow of a 3rd party app authenticating and using the latest SSO lib in combination with the latest beta files app
  3. Having an real end to end test, which covers the flow of a 3rd party app authenticating and using the latest stable SSO sample app in combination with the latest files app

➡️ Proposal

In order to achieve goal 2 and 3, i came to the conclusion that we eventually need two separate test flows. One should be located in the repository of the SSO lib and one in the repository of the files app.

Testing flows

We already know that those tests will have a quite long runtime due to the usage of an AVD emulator. Ideally they will run on each push event, but i am also fine with setting up a nightly running job. Maybe listening to push events makes sense for the SSO lib (where less commits are made, and we usually have more time), while setting up a nightly job for the files app.

Files app

  1. Setup a temporary server using the Docker image
  2. Run emulator
  3. Fetch (or clone) and install the latest stable SSO sample app, for example via GitHub, jitpack.io or F-Droid (given the sample app will be published there)
  4. Build and install the current files app
  5. Run actual test

SSO lib

  1. Setup a temporary server using the Docker image
  2. Run emulator
  3. Fetch and install the latest beta files app
  4. Build and install the current files app
  5. Run actual test

I would love to get some feedback from @tobiasKaminsky @David-Development @desperateCoder - also feel free to ping everyone who might be interested, wants to join forces or can provide further information (for example regarding Docker.

@tobiasKaminsky

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tobiasKaminsky

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tobiasKaminsky
Copy link
Member

I suggest you start with a PR and I can jump in when you need help :)

stefan-niedermann added a commit that referenced this issue Nov 3, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 4, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 4, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 4, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 4, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 4, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Nov 5, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann linked a pull request Nov 5, 2021 that will close this issue
6 tasks
stefan-niedermann added a commit that referenced this issue Nov 6, 2021
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 19, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Feb 16, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Feb 16, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Feb 16, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Feb 16, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Mar 4, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Mar 4, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Mar 4, 2024
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Mar 4, 2024
As suggested in #404 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants