Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more debugging output / destroy api when reconnect fails #163

Merged
merged 10 commits into from
Feb 19, 2020
Merged

add more debugging output / destroy api when reconnect fails #163

merged 10 commits into from
Feb 19, 2020

Conversation

David-Development
Copy link
Member

@David-Development David-Development commented Jan 21, 2020 •
edited
Loading

Closes #162

@David-Development
Copy link
Member Author

@stefan-niedermann @desperateCoder did you guys manage to test the changes proposed in the MR?

@stefan-niedermann
Copy link
Member

Not yet, sry

David-Development and others added 9 commits February 18, 2020 16:46
@David-Development
remove duplicate code
f0a5a06
@David-Development
unbind and re-bind service when service connection is lost / add more…
62fc982 
… logging

Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
fix typo
5652e31
@stefan-niedermann @David-Development
VersionCheckHelper::getNextcloudFilesVersionCode only needs Context
1302ea6 
Signed-off-by: David Luhmer <david-dev@live.de>
@stefan-niedermann @David-Development
Add Context import statement
94bc955 
Signed-off-by: David Luhmer <david-dev@live.de>
@dlwetteronline @David-Development
add more debugging output / destroy api when reconnect fails
84e778a 
Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
remove duplicate code
985e332 
Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
unbind and re-bind service when service connection is lost / add more…
5a7d933 
… logging

Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
Merge branch 'fix-api-not-responding' of https://github.com/nextcloud…
2a9ca9f 
…/Android-SingleSignOn into fix-api-not-responding
@nextcloud-android-bot
Copy link
Collaborator

Codacy

29

Lint

TypemasterPR
Warnings22
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings2
Correctness Warnings15
Internationalization Warnings3
Multithreaded correctness Warnings3
Performance Warnings5
Security Warnings5
Dodgy code Warnings9
Total42

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings2
Correctness Warnings12
Internationalization Warnings3
Multithreaded correctness Warnings3
Performance Warnings5
Security Warnings5
Dodgy code Warnings9
Total39

@David-Development David-Development mentioned this pull request Feb 18, 2020
Open
@David-Development David-Development changed the title WIP: add more debugging output / destroy api when reconnect fails add more debugging output / destroy api when reconnect fails Feb 19, 2020
@tobiasKaminsky tobiasKaminsky merged commit 9c93c87 into master Feb 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-api-not-responding branch February 19, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NextcloudApiNotRespondingException
5 participants
@David-Development @stefan-niedermann @nextcloud-android-bot @tobiasKaminsky @dlwetteronline