-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if users is set #1281
Check if users is set #1281
Conversation
In which case can it be empty? Do you have reproduction steps? |
No sorry, just some errors like these in the logs... |
I am wondering if this won't juste hide another issue. Can you investigate ? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Maybe. Do you still have the log? |
This will also fix:
Can we go ahead and merge + backport it? |
I think this should be fixed in |
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix psalm Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Use empty array if array is unset Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2 flaky tests on run #1518 ↗︎
Details:
cypress/e2e/sidebar.cy.ts • 2 flaky tests • Run E2E
Review all test suite changes for PR #1281 ↗︎ |
I think this is still valid to not just hide issues |
Maybe, but as long as I don't see this in logs a long time ago, and this PR is not the good approach anyway, closing here 👍 |
Error: Undefined array key "users"
Exception: array_keys(): Argument #1 ($array) must be of type array, null given