add comment functionality to activity tab #1387
Conversation
Signed-off-by: Stephan Orbaugh <stephan.orbaugh@nextcloud.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
feature/sorbaugh/combine-comments-and-activity-tabs
branch
from
fe2d8b8
to
2db136a
Compare
| @@ -0,0 +1,31 @@ | |||
| <!-- TODO: Move to vue components --> | |||
| import moment from '@nextcloud/moment' | ||
|
|
||
| export default { | ||
| name: 'Moment', |
| //const newComment = await NewComment(this.commentsType, this.ressourceId, message) | ||
| const newComment = await NewComment('files', 3, message) | ||
| // this.logger.debug('New comment posted', { commentsType: this.commentsType, ressourceId: this.ressourceId, newComment }) |
src/sidebar.js
Outdated
| // only load if needed | ||
| if (ActivityTabView === null) { | ||
| const { default: ActivityTab } = await import('./views/ActivityTab.vue') | ||
| ActivityTabView = ActivityTabView ?? Vue.extend(ActivityTab) | ||
| } | ||
| // destroy previous instance if available | ||
| const { default: ActivityTab } = await import(/* webpackPreload: true */ './views/ActivityTab.vue') | ||
| ActivityTabView = ActivityTabView ?? Vue.extend(ActivityTab) |
There was a problem hiding this comment.
Won't this revert this optimisation?
#1363
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
Closing in favor of #1416 |
susnux
deleted the
feature/sorbaugh/combine-comments-and-activity-tabs
branch
Issue: https://github.com/nextcloud-gmbh/server/issues/521
Mockups: nextcloud/server#658