Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkboxes alignment and add proper spacing to frequency select #1660

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix checkboxes alignment and add proper spacing to frequency select #1660

merged 2 commits into from
Apr 30, 2024

Conversation

marcoambrosini
Copy link
Member

Screenshot 2024-04-29 at 12 52 56 Screenshot 2024-04-29 at 12 52 59

@marcoambrosini marcoambrosini self-assigned this Apr 29, 2024
@szaimen
Copy link
Contributor

szaimen commented Apr 29, 2024

/compile

@szaimen szaimen added this to the Nextcloud 30 milestone Apr 29, 2024
@szaimen szaimen enabled auto-merge April 29, 2024 10:57
@marcoambrosini @szaimen
Fix checkboxes alignment and add proper spacing to frequency select
9abd6e3 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@szaimen
Copy link
Contributor

szaimen commented Apr 29, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
e50becd 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress Cypress
Copy link

cypress bot commented Apr 29, 2024 •
edited
Loading

Passing run #1490 ↗︎

0 10 0 0 Flakiness 0

Details:

Fix checkboxes alignment and add proper spacing to frequency select
Project: Activity Commit: d1726b2ac7
Status: Passed Duration: 02:23 💡
Started: Apr 30, 2024 11:40 AM Ended: Apr 30, 2024 11:42 AM

Review all test suite changes for PR #1660 ↗︎

artonge
artonge approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would appreciate a before/after

@szaimen szaimen merged commit af356ee into master Apr 30, 2024
44 checks passed
@szaimen szaimen deleted the design-fixes branch April 30, 2024 12:17
@marcoambrosini marcoambrosini mentioned this pull request May 10, 2024
Open
29 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoambrosini @szaimen @artonge @nextcloud-command