Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bump happy-dom from 14.10.1 to 14.12.3 #1720

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2024

Bumps happy-dom from 14.10.1 to 14.12.3.

Release notes

Sourced from happy-dom's releases.

v14.12.3

πŸ‘·β€β™‚οΈ Patch fixes

  • Fixes bug related to Node.insertBefore() handling the scenario where the reference node equals the new node to be added incorrectly - By @​juandiegombr in task #1429

v14.12.2

πŸ‘·β€β™‚οΈ Patch fixes

  • Fixes problem related to the cookie container using the wrong path when caching cookies - By @​matcic in task #1455

v14.12.1

πŸ‘·β€β™‚οΈ Patch fixes

  • Fixes problem related to React click handler with preventDefault not preventing navigation - By @​amitdahan in task #1464

v14.12.0

🎨 Features

  • Makes it possible to configure timer settings to improve performance - By @​capricorn86 in task #1451
    • Read more about the new settings in the Wiki
  • Groups timers with a delay of 0 into one timer to improve performance and make waitUntilComplete() less likely to resolve too early - By @​capricorn86 in task #1451

v14.11.4

πŸ‘·β€β™‚οΈ Patch fixes

  • Fixes bug where waitUntilComplete() was resolved too early when many micro tasks are used - By @​capricorn86 in task #1447
    • The patch in v14.11.3 didn't completely resolve the issue

v14.11.3

πŸ‘·β€β™‚οΈ Patch fixes

  • Fixes bug where waitUntilComplete() was resolved too early when many micro tasks are used - By @​capricorn86 in task #1447

v14.11.2

πŸ‘·β€β™‚οΈ Patch fixes

  • Adds fix to update CSS rules in HTMLStyleElement sheet when editing the data of a child Text node - By @​capricorn86 in task #1445

v14.11.1

πŸ‘·β€β™‚οΈ Patch fixes

  • Adds a temporary fix where waitUntilComplete() will hook into promises returned by connectedCallback() until Happy DOM has support for waiting for dynamic imports - By @​capricorn86 in task #1442
    • It is common do make dynamic imports in connectedCallback() of web components. As Happy DOM doesn't have support for dynamic imports in waitUntilComplete(), a temporary fix has been added to hook into promises returned by connectedCallback().

v14.11.0

🎨 Features

v14.10.3

πŸ‘·β€β™‚οΈ Patch fixes

  • Adds check for if Window and MutationObserver has been destroyed when triggering listeners - By @​capricorn86 in task #1436

v14.10.2

πŸ‘·β€β™‚οΈ Patch fixes

  • HTMLAnchorElement, HTMLButtonElement, HTMLInputElement and HTMLLabelElement checked that click events triggering native behavior was of type PointerEvent, but should check that they are of type MouseEvent - By @​capricorn86 in task #1397
Commits
  • e6f9127 Merge pull request #1453 from juandiegombr/master
  • fbb71ce Merge branch 'master' into master
  • 3504a93 Merge pull request #1456 from matcic/1455
  • 2aab0d5 Merge branch 'master' into 1455
  • 8da51ee Merge pull request #1465 from amitdahan/fix-anchor-react-click-preventDefault
  • a3b6d86 fix: #1464 Fix React click handler with preventDefault not preventing nav...
  • 80bbc41 chore: #1464 Add failing test
  • 4bf250c fix: #1455 Cookie container cache key
  • 221e22b fix: #1429 Element.insertBefore works when the node is already inserted
  • ef2dfea Merge pull request #1452 from capricorn86/1451-make-it-possible-to-configure-...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review dependencies Pull requests that update a dependency file labels Jul 9, 2024
@AndyScherzinger
Copy link
Member

/compile /

Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 9, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link

cypress bot commented Jul 9, 2024

3 flaky tests on run #1672 β†—οΈŽ

0 10 0 0 Flakiness 3

Details:

Upgrade: Bump happy-dom from 14.10.1 to 14.12.3
Project: Activity Commit: c261dc1611
Status: Passed Duration: 03:39 πŸ’‘
Started: Jul 12, 2024 2:18 PM Ended: Jul 12, 2024 2:22 PM
FlakinessΒ  cypress/e2e/sidebar.cy.ts β€’ 3 flaky tests β€’ Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots
Check activity listing in the sidebar > Has comment activity Test Replay Screenshots

Review all test suite changes for PR #1720 β†—οΈŽ

@AndyScherzinger
Copy link
Member

@dependabot recreate

Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 14.10.1 to 14.12.3.
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v14.10.1...v14.12.3)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/happy-dom-14.12.3 branch from b9ad9d8 to 5536bfd Compare July 12, 2024 14:13
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@AndyScherzinger
Copy link
Member

/compile /

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jul 12, 2024
@dependabot dependabot bot merged commit 76d2c61 into master Jul 12, 2024
45 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/happy-dom-14.12.3 branch July 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants