fix(DigestSender): Do not add and 1 more in digest mail but simply include it
#1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed test on run #1717 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has comment activity |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1723 ↗︎
AndyScherzinger
approved these changes
Jul 12, 2024
miaulalala
approved these changes
Jul 15, 2024
artonge
approved these changes
Jul 15, 2024
…include it 1 more makes no sense as we can simply show that additional activity, so instead show it if there is only one more activity. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/no-and-1-more
branch
from
e30344a
to
08b357a
Compare
|
Cypress unrelated, can someone force merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 more makes no sense as we can simply show that additional activity, so instead show it if there is only one more activity.