feat: Add sharing activity for teams #1754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
feat/activity-for-team-share
branch
from
b5c753a
to
0efac00
Compare
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
feat/activity-for-team-share
|
| Run status |
|
| Run duration | 02m 57s |
| Commit |
|
| Committer | Ferdinand Thiessen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
susnux
force-pushed
the
feat/activity-for-team-share
branch
3 times, most recently
from
77c13d1
to
b69f982
Compare
This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the `files_sharing` app. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/activity-for-team-share
branch
from
b69f982
to
2295c86
Compare
|
TIL: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the
files_sharingapp.So if this is merged we can add the required providers in
files_sharing.But one thing to mention: For groups we paginate the members, I did not find a nice way to do this with teams.
So maybe @ArtificialOwl can have a look at the member query if there is something to improve performance wise (e.g. pagination?).