notice on empty cachedPath #1776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
feat/noid/log-on-no-user
|
| Run status |
|
| Run duration | 03m 35s |
| Commit |
|
| Committer | Maxence Lange |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
artonge
reviewed
Sep 14, 2024
| @@ -1331,6 +1331,12 @@ private function getUnrelatedUsers(int $fileId, array $cachedMounts): array { | |||
| // now that we have a list of eventuals filtered users, we confirm they have no access to the file | |||
| $filteredUsers = []; | |||
| foreach ($usersToCheck as $userId) { | |||
| if (!array_key_exists($userId, $cachedPath) || $cachedPath[$userId] === null) { | |||
| $this->logger->notice('could not find user in list of cached path', ['cachePath' => $cachedPath, 'usersToCheck' => $usersToCheck, 'current' => $userId]); | |||
There was a problem hiding this comment.
I don't know whether it is an error or not. Shouldn't we try to fetch the user path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notice and ignore entries with empty cachedPath for userId.